PR Summary

Sci/Tech Reviewer: @tom-j-h
Code Reviewer: @stevemullerworth

Enable the tangent linear and adjoint models to use 32 bit precision and test.

• Update the adjoint_tests and linear_model iodef files so that W2 fields are not written out. This also includes splitting the iodef files into many small iodef files (to mirror the gungho_model iodef files) - this makes it easier to manage going forward.
• Correct the diagnostics source code so that xios only tries to write out fields if they are listed in the iodef file. (32 bit does not work for writing out W2 fields).
• Update the plotting to plot winds in W3 rather than W2 (as W2 are no longer in the diagnostic file).
• Update the adjoint test parameters to avoid dividing by zero errors.
• Add 32bit and 64bit tests, and with a variety of compilers, to the rose stem tests for linear_model and adjoint_tests. For adjoint_tests, slightly different solver settings are required for 32bit and 64 bit.

#111

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - linear_32bit/run7

Suite Information

Task Information

✅ succeeded tasks - 1151

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable